DO NOT MERGE: PoC fix for cluster services race #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept fix for race described by
https://github.com/azimuth-cloud/azimuth-capi-operator/pull/481(which will likely supersede this PR).on_cluster_services_updatednow must wait on afinishedfield in the cluster's status before updating Platform CRs. I don't think this is a genuine fix, it just seems to delay monitor_cluster_services long enough for the race not to occur. Checking forfinishedbeing true also isn't atomic so in itself is race-prone, not sure what the implications of using regular async locks are for kopf threads