lang: emit CRLF-separator blank line after email Subject headers#15
Merged
Essency merged 2 commits intoazzurra:masterfrom Apr 22, 2026
Merged
lang: emit CRLF-separator blank line after email Subject headers#15Essency merged 2 commits intoazzurra:masterfrom
Essency merged 2 commits intoazzurra:masterfrom
Conversation
Every *_EMAIL_SUBJECT .lang entry that maps to an RFC 5322 "Subject: ..."
header previously compiled to a body ending with a single '\n'. When
do_sendpass / do_sendcode / etc. fprintf the Subject line followed by
the email body, the output lacks the required blank line between
headers and body, so strict RFC 5322 parsers (e.g. the resend.com SMTP
relay used for nickserv-bounces@azzurra.chat) reject the message with
554 "Failed to parse email message".
Fix: add one extra tab-empty terminator after the Subject line in each
of the 12 subject-header entries per language, so the compiled .clng
body ends with '\n\n' — the blank-line separator strict parsers
require. Affects NS_{SENDCODE,SENDPASS,DROP,REGISTER,REMIND,SET}_EMAIL_SUBJECT,
CS_{DROP,REMIND,SENDPASS,SENDPASS_RPWD}_EMAIL_SUBJECT, and
MS_{SEND,SENDTO}_EMAIL_SUBJECT.
Leaves _AUTH/_DROP/_MAIL/_RPWD format-arg sub-entries untouched — those
are interpolated via %s into the parent Subject line and are not headers
themselves.
No langcomp / lang_msg_svc.h changes; parse-order and message IDs are
stable. Hot-reloadable via rehash once svc{IT,US,ES,FR}.clng are
regenerated.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
parse_lang skips fully-empty lines, so the blank line inside the body was dead weight. Per Sonic's review on the PR: keep only the trailing tab-empty terminators that actually shape the compiled output. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Test plan