Make expand_ipv6 use caller-provided buffer#17
Merged
Essency merged 1 commit intoazzurra:masterfrom Apr 27, 2026
Merged
Conversation
The memory management semantics of expand_ipv6() weren't specified explicitly, so callers never bothered with free()'ing its return value. This caused the IPv6 clone checker to leak memory like a sieve because the expand_ipv6() function would be called in a hot loop iterating over *every single IPv6 client*. Fix this ugly behavior by getting rid of dynamic memory allocation altogether and making expand_ipv6 take a caller-provided buffer to perform its work (some callers were copying its return value to an already existing buffer anyway...).
abonforti
approved these changes
Apr 27, 2026
Essency
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memory management semantics of
expand_ipv6()weren't specified explicitly, so callers never bothered with free()'ing its return value.This caused the IPv6 clone checker to leak memory like a sieve because the
expand_ipv6()function would be called in a hot loop iterating over every single IPv6 client.Fix this ugly behavior by getting rid of dynamic memory allocation altogether and making
expand_ipv6take a caller-provided buffer to perform its work (some callers were copying its return value to an already existing buffer anyway...).