Skip to content

[5 of 6] Add Go 1.25.x to CI test matrix and update dependencies#8

Closed
b-long wants to merge 1 commit intostacked/04-c23-compatibilityfrom
stacked/05-add-go-1.25
Closed

[5 of 6] Add Go 1.25.x to CI test matrix and update dependencies#8
b-long wants to merge 1 commit intostacked/04-c23-compatibilityfrom
stacked/05-add-go-1.25

Conversation

@b-long
Copy link
Copy Markdown
Owner

@b-long b-long commented Jan 25, 2026

This PR is stacked atop:

Summary

  • Adds Go 1.25.x to the CI test matrix
  • Updates golang.org/x/tools dependency to support Go 1.25.x
  • Ensures gopy works with the latest Go version

Changes

  • Updated CI matrix to test Go 1.25.x, 1.24.x, 1.22.x, and 1.21.x
  • Upgraded golang.org/x/tools from v0.16.0 to v0.29.0 (required for Go 1.25 compatibility)
  • Updated go.mod go directive to 1.22.0 (automatically set by go mod tidy)

Why the dependency update?

Go 1.25 introduced breaking changes that make golang.org/x/tools v0.16.0 incompatible. The error was:

golang.org/x/tools@v0.16.0/internal/tokeninternal/tokeninternal.go:78:9: 
invalid array length -delta * delta (constant -256 of type int64)

Upgrading to v0.29.0 fixes this compatibility issue.

Test Plan

  • CI will verify builds pass with all four Go versions
  • Two tests remain skipped due to known Go 1.21+ CGO issues (expected)

Next PR in the queue should be #9 *Edit: This was stated in error, and this work is incomplete.

Next PR in the queue should be:

Adds Go 1.25.x to the CI test matrix alongside existing versions
(1.25.x, 1.24.x, 1.22.x, 1.21.x). This ensures gopy works with
the latest Go version.

Updates golang.org/x/tools from v0.16.0 to v0.29.0 to support
Go 1.25.x, which has breaking changes that make older versions
of x/tools incompatible.

Note: Two tests remain skipped due to known Go 1.21+ CGO issues
(see go-python#370). This is expected.
@b-long
Copy link
Copy Markdown
Owner Author

b-long commented Apr 11, 2026

Superseded by go-python#384

@b-long b-long closed this Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant