fix(types): skip None fields in FillsHistoryParams query serialization#109
Merged
Conversation
|
Why not add a test as well ? |
extremeandy
force-pushed
the
fix/fills-history-query-signing
branch
3 times, most recently
from
f58bc67 to
77333a6
Compare
serde_qs 1.1.x emits bare keys for unset Options, which breaks signature verification on get_historical_fills. Omit None fields like other query types.
extremeandy
force-pushed
the
fix/fills-history-query-signing
branch
from
77333a6 to
ba1e064
Compare
udsamani
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_serializing_if = "Option::is_none"to optional fields onFillsHistoryParamsget_historical_fillsafter the serde_qs 1.1.x bump, which serializes unsetOptions as bare keys