chore: fix notices and warnings in tests#122
Merged
Merged
Conversation
garak
force-pushed
the
fix-phpunit-notices
branch
from
July 20, 2026 12:48
5a24f03 to
03654c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying the test suite locally, I realised that we had PHPUnit green but Behat red.
I'm proposing a small change in the fixtures, so now both are green.
To avoid making the same mistake again, I'm also adding a Behat step to the CI.
Finally, PHPUnit is now free from notices and warnings.