Added datastore property to registeredDryModels#467
Open
sveingunnarlarsen wants to merge 2 commits into
Open
Conversation
|
I can confirm there is a problem if you, like me, are trying to use a test watcher and need to reinitialize waterline. Is there any problem with this PR ? @particlebanana @mikermcneil |
tugorez
added a commit
to spaceship-labs/sails-mongo
that referenced
this pull request
Jun 20, 2018
be able to remove the model from registeredDryModels so we can avoid registerDatastore to throw "Consitency violation" error if you need to reinitialize waterline. please see balderdashy#467 for more information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added datastore to registeredDryModels as teardown uses this property to remove models from the adapter, i.e.
In registerDatastore the property datastore is not added to registeredDryModels, i.e.
Which means that registeredDryModels[modelIdentity].datastore will always be undefined and not remove the model from registeredDryModels causing registerDatastore to throw "Consitency violation" error if you need to reinitialize waterline.