Skip to content

feat: Prompt for optional <all_urls> permission in onboarding and popup#242

Merged
bartekplus merged 5 commits intomasterfrom
fix_firefox_permision
Mar 1, 2026
Merged

feat: Prompt for optional <all_urls> permission in onboarding and popup#242
bartekplus merged 5 commits intomasterfrom
fix_firefox_permision

Conversation

@bartekplus
Copy link
Owner

As per user feedback, the extension declared `<all_urls>` in the manifest as an `optional_host_permissions`, but this permission was never presented to the user to grant.

This PR introduces the following changes:

  • Onboarding Flow: The installation greeting page now actively prompts the user to grant the `<all_urls>` permission.
  • Popup UI: If the permission is missing (e.g., skipped during install or revoked later), a red "Action Required" banner appears at the top of the popup menu to let the user know website access is needed.
  • E2E Testing: The Puppeteer E2E tests have been updated with a mock of the `browser.permissions.request` API to validate the new onboarding flow's behavior.
  • I18n: Added translation keys `popup_permission_required` and `popup_permission_grant` to `i18n.js` for all 9 supported languages.

@bartekplus bartekplus self-assigned this Mar 1, 2026
@bartekplus bartekplus added bug Something isn't working enhancement New feature or request labels Mar 1, 2026
@bartekplus bartekplus merged commit 54dda59 into master Mar 1, 2026
6 checks passed
@bartekplus bartekplus deleted the fix_firefox_permision branch March 1, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant