Skip to content

ignore lock file and python-version - #181

Open
amirreza-sf80 wants to merge 1 commit into
baseplate-admin:masterfrom
amirreza-sf80:master
Open

ignore lock file and python-version#181
amirreza-sf80 wants to merge 1 commit into
baseplate-admin:masterfrom
amirreza-sf80:master

Conversation

@amirreza-sf80

Copy link
Copy Markdown
Collaborator

reason being that this package should be usable with different versions of python and dependencies, and it is tested against different environments, so locking doesn't make much sense to me

@baseplate-admin

Copy link
Copy Markdown
Owner

Well i kept the lock file to auto update the deps in the repo, without lock file the dependabot breaks with uv.

Can we do something like this:

  1. Use TOX? many projects are using tox ( for example monkeytype )
  2. maybe we can just stick with github ci/cd and remove the .python-version file? (which is the tool locking python to one version)

Would be happy to have your input on this :)

@amirreza-sf80

Copy link
Copy Markdown
Collaborator Author

hi
about tox, I've not used it enough to form an opinion, i could try to see

about dependency update, emm, i would say if there's a dependency that doesn't require specific versions and is safe to auto update, we can just not set a version in pyproject.
otherwise I don't think it should be updated automatically
for example what django version we support shouldn't be determined by dependebot

at least that's my understanding.

@baseplate-admin

Copy link
Copy Markdown
Owner

So, basically in this repo, the docs and the dev tools are version controlled by the same uv.lock.

So if a new version of sphinx releases or the docs theme (furo) gets any update, the dependabot will automatically pick those changes up and update them. django wont be updated by uv nor should it care about locking django. also in github-actions, we are explicitly installing new django version by giving

uv pip install django==${{ matrix.django-version }}

This command.

So overall, if we merge this PR, our docs and the docs theme will not get automatic updates,
(same can be said for the actual testing tools)


The only thing we should merge from this PR is the deletion of the .python-version file, that will help with the issue that you mentioned here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants