Add '~' to the list of characters allowed in external workspace roots. - #422
Open
cdrichards wants to merge 1 commit into
Open
Add '~' to the list of characters allowed in external workspace roots.#422cdrichards wants to merge 1 commit into
cdrichards wants to merge 1 commit into
Conversation
…names. This allows ffap to find files pulled in by a Bzlmod bazel_dep() declaration. Tested manually by following the current abseil-cpp quickstart for Bazel [1] and successfully running ffap on the include "absl/strings/str_join.h". I tried to update the unit tests, but I only got as far as getting 'bazel test bazel_test' to fail during compilation of a sandbox emacs binary. (Details available on request.) [1] https://github.com/abseil/abseil.github.io/blob/3d821c30eb5c00b95a76fa044a1a10ea94c587a1/docs/cpp/quickstart.md
Collaborator
|
Sorry for the huge delay, this repository was "locked" for quite a while. Could you try to rebase? |
phst
self-requested a review
April 13, 2026 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows ffap to find files pulled in by a
bazel_dep()declaration.Tested manually by following the current abseil-cpp quickstart for Bazel and successfully running ffap on the include
"absl/strings/str_join.h".I tried to update the unit tests, but I only got as far as getting
bazel test bazel_testto fail during compilation of a sandbox emacs binary. (Details available on request.)