Skip to content

ci: disable bazel-diff due to platform compatibility conflicts#3840

Merged
rickeylev merged 3 commits into
bazel-contrib:mainfrom
rickeylev:disable-bazel-diff
Jun 21, 2026
Merged

ci: disable bazel-diff due to platform compatibility conflicts#3840
rickeylev merged 3 commits into
bazel-contrib:mainfrom
rickeylev:disable-bazel-diff

Conversation

@rickeylev

@rickeylev rickeylev commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

This PR disables the bazel-diff target filtering to repair the CI. Since we
make heavy use of target_compatible_with to restrict tests to specific
platforms, and Bazel CI's bazel-diff integration isn't able to handle those.

We disable bazel-diff target filtering to repair the CI.

Since this project makes heavy use of target_compatible_with to restrict tests to specific platforms, and Bazel CI's bazel-diff runner operates in plain query mode (which ignores compatibility), it erroneously schedules incompatible tests on the wrong runners and breaks the build. Attempts to use EXP_USE_CQUERY=true also did not resolve this reliably.

We comment out USE_BAZEL_DIFF and add an explanatory comment in .bazelci/presubmit.yml.
@rickeylev rickeylev requested a review from aignas as a code owner June 21, 2026 03:44

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the USE_BAZEL_DIFF environment variable in the Bazel CI presubmit configuration (.bazelci/presubmit.yml) and adds a detailed comment explaining that the built-in bazel-diff integration runs in plain query mode, which ignores target compatibility and causes build failures. The reviewer suggested removing the commented-out environment block entirely to keep the configuration file clean and maintainable.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

.bazelci/presubmit.yml (34-36)

medium

To keep the configuration file clean and maintainable, it is recommended to completely remove the commented-out environment block. The detailed comment above already explains why USE_BAZEL_DIFF is disabled, making the commented-out code redundant.

  # resolve this reliably.

@rickeylev rickeylev merged commit e9ecdba into bazel-contrib:main Jun 21, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant