fix: use locale-neutral Windows ACL for build data#3887
Conversation
On localized Windows installs, resolving the English Everyone principal can fail when build_data_writer.ps1 creates the output file ACL. This breaks build data generation on systems such as German Windows. Use the language-neutral WorldSid identity instead, preserving the existing Everyone read permission without depending on localized account names.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes build data generation on localized Windows installations by replacing the hardcoded 'Everyone' group name with the language-independent 'WorldSid' security identifier in the PowerShell script build_data_writer.ps1. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request fixes build data generation on localized Windows installations by replacing the hardcoded "Everyone" group name with the well-known SID for the World group (WellKnownSidType::WorldSid) in the PowerShell script build_data_writer.ps1. This ensures compatibility across non-English Windows environments. There are no review comments, so I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
We use WorldSid because the 'Everyone' name is locale-dependent.
|
TIL. Thanks for the fix! |
On localized Windows installations, `build_data_writer.ps1` could fail when creating the output file ACL because it used the English localized `Everyone` principal name. This changes the ACL rule to use the language-neutral `WorldSid` identity instead, preserving the existing Everyone read permission without depending on the display language of Windows. Before: German and other localized Windows installs could fail with `IdentityMappedException` / `IdentityNotMappedException`. After: build data generation succeeds on localized Windows installs. Fixes #3886 Tests: `bazelisk test //tests/build_data:build_data_test --config=fast-tests` --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com> (cherry picked from commit 8629003) Work towards #3867
2 participants
On localized Windows installations,
build_data_writer.ps1could fail whencreating the output file ACL because it used the English localized
Everyoneprincipal name.
This changes the ACL rule to use the language-neutral
WorldSididentityinstead, preserving the existing Everyone read permission without depending on
the display language of Windows.
Before: German and other localized Windows installs could fail with
IdentityMappedException/IdentityNotMappedException.After: build data generation succeeds on localized Windows installs.
Fixes #3886
Tests:
bazelisk test //tests/build_data:build_data_test --config=fast-tests