Skip to content

Fix release tool links and improve workflow robustness#3888

Merged
rickeylev merged 2 commits into
bazel-contrib:mainfrom
rickeylev:fix-release-tool-links
Jul 3, 2026
Merged

Fix release tool links and improve workflow robustness#3888
rickeylev merged 2 commits into
bazel-contrib:mainfrom
rickeylev:fix-release-tool-links

Conversation

@rickeylev

Copy link
Copy Markdown
Collaborator

Fixes release tool bugs and improves workflow robustness.

  • Fix BCR entry link in create-rc to use RC version instead of final version.
  • Format BCR entry link as 'BCR Entry '.
  • Fix release workflow status link to use release_create_rc.yaml.
  • Use GITHUB_RUN_ID to link directly to the workflow run if available.
  • Link the branch name in the create-rc comment.
  • Add a always-running job to release_create_release_branch.yaml to suppress 'no jobs ran' errors.
  • Remove obsolete rocket assertions in create_rc tests.

rickeylev added 2 commits July 3, 2026 02:37
- Fix BCR entry link in create-rc to use RC version instead of final version.
- Format BCR entry link as 'BCR Entry <version>'.
- Fix release workflow status link to use release_create_rc.yaml.
- Use GITHUB_RUN_ID to link directly to the workflow run if available.
- Link the branch name in the create-rc comment.
- Add a always-running job to release_create_release_branch.yaml to suppress 'no jobs ran' errors.
@rickeylev rickeylev requested a review from aignas as a code owner July 3, 2026 02:55

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release candidate creation script to dynamically generate markdown links for the release branch, BCR entry, and GitHub Actions workflow run (using GITHUB_RUN_ID if available), and updates the corresponding unit tests. The feedback suggests addressing potential environment leakage in tests (specifically GITHUB_RUN_ID and GITHUB_OUTPUT) to prevent test failures in CI, and moving the inline import of the os module to the top of the file to comply with PEP 8 guidelines.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/tools/private/release/create_rc_test.py
Comment thread tools/private/release/create_rc.py
@rickeylev rickeylev merged commit 8396c28 into bazel-contrib:main Jul 3, 2026
4 of 6 checks passed
@rickeylev rickeylev deleted the fix-release-tool-links branch July 3, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant