chore(release): fix promote_rc arguments and align comments#3898
Conversation
`promote_rc.py` was calling `Git.fetch` with `refspec` keyword argument which was not supported by `Git.fetch` signature, leading to fatal errors. The release promotion comment format was different from the release candidate creation comment format, leading to inconsistency. - Added `refspec` argument support to `Git.fetch` in `git.py`. - Added `sys.argv` printing at startup in `release.py` for debugging. - Updated `promote_rc.py` comment body to match `create_rc.py` style and added necessary helper variables. - Updated `git_test.py` to test `Git.fetch` with `refspec`. - Updated `promote_rc_test.py` to match the new comment format.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the release promotion process by formatting and adding more detailed links (such as branch, BCR entry, and workflow status) to the tracking issue comment. It also extends the Git helper's fetch method to support a refspec parameter and adds corresponding unit tests. Feedback on the changes suggests redirecting the newly added debug print of sys.argv in release.py to sys.stderr to avoid interfering with standard output parsing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
chore(release): fix promote_rc arguments and align comments
promote_rc.pywas callingGit.fetchwithrefspeckeyword argument which was not supported byGit.fetchsignature, leading to fatal errors.The release promotion comment format was different from the release candidate creation comment format, leading to inconsistency.
refspecargument support toGit.fetchingit.py.sys.argvprinting at startup inrelease.pyfor debugging.promote_rc.pycomment body to matchcreate_rc.pystyle and added necessary helper variables.git_test.pyto testGit.fetchwithrefspec.promote_rc_test.pyto match the new comment format.