chore(release): fix promote-rc command and update workflow args#3899
Merged
Conversation
The promote-rc command was failing because it called Git.get_commit_sha with an invalid keyword argument 'remote_ref'. This fixes the call and updates the tests. It also updates the workflow to use '=' for passing arguments as requested.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the invocation of get_commit_sha in promote_rc.py and its corresponding tests by passing the remote branch as a positional argument instead of a keyword argument (remote_ref). I have no further feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
promote-rccommand fails because it callsGit.get_commit_shawith an invalid keyword argumentremote_ref. Additionally, we want to align argument passing in the workflow with the=style.To fix this:
remote_refkeyword argument fromGit.get_commit_shacall inpromote_rc.py.promote_rc_test.pymock assertions to match the corrected call.release_promote_rc.yamlto pass--issueand--remotearguments using=.