Repository navigation
[9.3.2] Fix linux-sandbox actions being killed prematurely when using virtual… - #32342
Merged
Merged
Conversation
… threads (bazelbuild#31017) This is a version of bazelbuild#29007 where the added test should pass for MacOS. The only change in this PR vs that PR is the location of `true` varies based on OS. I think this should work, but I don't have a Mac handy to test this. If anyone has a Mac and can run `bazel test //src/test/java/com/google/devtools/build/lib/shell:JavaSubprocessFactoryTest` then that'd be much appreciated. I forgot to account for the fact that MacOS places `true` at `/usr/bin/true` instead of `/bin/true`. This was the error during postsubmit from that test on MacOS: ``` 1) createFromVirtualThreadForksOnPlatformThread(com.google.devtools.build.lib.shell.JavaSubprocessFactoryTest) java.lang.AssertionError: Error running subprocess from virtual thread at com.google.devtools.build.lib.shell.JavaSubprocessFactoryTest.createFromVirtualThreadForksOnPlatformThread(JavaSubprocessFactoryTest.java:87) ... 23 trimmed Caused by: java.io.IOException: Cannot run program "/bin/true": Exec failed, error: 2 (No such file or directory) ``` Closes bazelbuild#31017. PiperOrigin-RevId: 977850652 Change-Id: Ideba552c30cb0804c2e8722b31cbaf12c9beb077
iancha1992
added
team-OSS
iancha1992
enabled auto-merge (squash)
November 2, 2026 17:03
Member
Author
|
@Wyverald @meteorcloudy @coeuvre Cherry-pick of feafed5 (#31017) into Conflict Resolution Note for Reviewers:
|
Wyverald
approved these changes
Nov 2, 2026
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… threads (#31017)
This is a version of #29007 where the added test should pass for MacOS. The only change in this PR vs that PR is the location of
truevaries based on OS.I think this should work, but I don't have a Mac handy to test this. If anyone has a Mac and can run
bazel test //src/test/java/com/google/devtools/build/lib/shell:JavaSubprocessFactoryTestthen that'd be much appreciated.I forgot to account for the fact that MacOS places
trueat/usr/bin/trueinstead of/bin/true. This was the error during postsubmit from that test on MacOS:Closes #31017.
PiperOrigin-RevId: 977850652
Change-Id: Ideba552c30cb0804c2e8722b31cbaf12c9beb077
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit feafed5