Repository navigation
[8.9.0] Only depend on the coverage wrapper when collecting coverage (#32015) - #32355
Merged
Merged
Conversation
…ild#32015) ### Description Starlark test rules now only depend on `@bazel_tools//tools/test:collect_coverage` if `--collect_code_coverage` is set. The dependency is late-bound, matching how the other coverage tools are handled. ### Motivation Since bazelbuild#26603, `@bazel_tools//tools/test:collect_coverage` is an `sh_binary`, which fails analysis on Windows if no shell is available. Since every Starlark test rule had an unconditional implicit dependency on it, all tests failed analysis on Windows machines without Bash, even without coverage. Fixes bazelbuild#32011 ### Build API Changes No ### Release Notes RELNOTES: Tests on Windows no longer require Bash unless coverage is collected. Closes bazelbuild#32015 COPYBARA_INTEGRATE_REVIEW=bazelbuild#32015 from fmeum:ccr-90e0c8f5-ic1d0m 1d0e2d4 PiperOrigin-RevId: 1010501355 Change-Id: I13117a753e72ddad155925e8254437f78c3e72f4
iancha1992
added
team-Configurability
iancha1992
enabled auto-merge
November 2, 2026 22:54
Member
Author
|
@c-mita @meteorcloudy The following files had merge conflicts or required manual adjustments for
|
meteorcloudy
approved these changes
Nov 3, 2026
meteorcloudy
disabled auto-merge
November 3, 2026 10:08
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Starlark test rules now only depend on
@bazel_tools//tools/test:collect_coverageif--collect_code_coverageis set. The dependency is late-bound, matching how the other coverage tools are handled.Motivation
Since #26603,
@bazel_tools//tools/test:collect_coverageis ansh_binary, which fails analysis on Windows if no shell is available. Since every Starlark test rule had an unconditional implicit dependency on it, all tests failed analysis on Windows machines without Bash, even without coverage.Fixes #32011
Build API Changes
No
Release Notes
RELNOTES: Tests on Windows no longer require Bash unless coverage is collected.
Closes #32015
COPYBARA_INTEGRATE_REVIEW=#32015 from fmeum:ccr-90e0c8f5-ic1d0m 1d0e2d4 PiperOrigin-RevId: 1010501355
Change-Id: I13117a753e72ddad155925e8254437f78c3e72f4
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit d458fab