[iancha1992]

Before this, it was checked against the rule using the subrule.

Fixes #31168

RELNOTES: Visibility of implicit dependencies of subrules are checked against the subrule package instead of that of the rule.
PiperOrigin-RevId: 1004754823
Change-Id: I5abdeac5ef2f914e4dee46eb2f9778905c84f1ac

Description

Motivation

Build API Changes

No

Checklist

• I have added tests for the new use cases (if any).
• I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

Commit e5729e7

[iancha1992]

@hvadehra

Cherry-pick of e5729e7 into release-8.9.0.

The following files had merge conflicts or required manual adjustments for release-8.9.0 and should be reviewed more closely:

• src/main/java/com/google/devtools/build/lib/analysis/BUILD: Added //src/main/java/com/google/devtools/build/lib/starlarkbuildapi to common_prerequisite_validator while preserving //third_party:guava and //third_party:jsr305 on release-8.9.0.
• src/main/java/com/google/devtools/build/lib/analysis/CommonPrerequisiteValidator.java: Adapted the subrule implicit dependency visibility check in validateDirectPrerequisiteVisibility to release-8.9.0 (which does not use VisibilityCheckState), resolving implicitDefinition to owningSubrule.getExtensionLabel() when maybeGetOwningSubrule matches.
• src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkSubrule.java: Resolved a nearby conflict with repr(Printer printer) and retained the StarlarkCallable import used on release-8.9.0.