Add missing rustc binaries to rustc_lib filegroup #3727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `rust-objcopy` and `wasm-component-ld` to the rustc_lib filegroup in repository_utils.bzl. These binaries are present in recent rustc distributions (wasm-component-ld since 1.82.0, rust-objcopy since 1.84.0) but were not declared in the filegroup. On Windows, Bazel copies files into the sandbox rather than symlinking, so only explicitly listed files are available. This caused wasm32-wasip2 builds to fail with "linker 'wasm-component-ld.exe' not found". On Linux/macOS, the issue was masked by symlink-based sandboxing which allowed access to unlisted files in the same directory.
avrabe
force-pushed
the
fix/add-missing-rustc-binaries
branch
from
738871d to
b715cc7
Compare
avrabe
added a commit
to pulseengine/rules_wasm_component
that referenced
this pull request
Nov 13, 2025
Testing PR bazelbuild/rules_rust#3727 which adds wasm-component-ld.exe and rust-objcopy.exe to rustc_lib filegroup. This should fix Windows wasm32-wasip2 builds by ensuring the linker is copied into the Bazel sandbox. Issue: avrabe/rules_rust#8
avrabe
added a commit
to pulseengine/rules_wasm_component
that referenced
this pull request
Nov 14, 2025
Testing PR bazelbuild/rules_rust#3727 which adds wasm-component-ld.exe and rust-objcopy.exe to rustc_lib filegroup. This should fix Windows wasm32-wasip2 builds by ensuring the linker is copied into the Bazel sandbox. Issue: avrabe/rules_rust#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
rust-objcopyandwasm-component-ldto therustc_libfilegroup inrepository_utils.bzl. These binaries are present in recent rustc distributions (wasm-component-ld since 1.82.0, rust-objcopy since 1.84.0) but were not previously declared.Changes
rust-objcopy{binary_ext}andwasm-component-ld{binary_ext}to the rustc_lib filegroup glob patternsContext
On Windows, Bazel copies files into the sandbox rather than symlinking, so only explicitly listed files are available. This caused wasm32-wasip2 builds to fail with
linker 'wasm-component-ld.exe' not found.On Linux/macOS, the issue was masked by symlink-based sandboxing which allowed rustc to access unlisted files in the same directory.