Use the more explicitly typed setObject method.#87
Open
Spasnof wants to merge 4 commits intobaztian:masterfrom
Open
Use the more explicitly typed setObject method.#87Spasnof wants to merge 4 commits intobaztian:masterfrom
Spasnof wants to merge 4 commits intobaztian:masterfrom
Conversation
Don't fail on dates before 1900 on Python < 3
Fixes the issue#57 by using the setobject method containing three arguments.
1 similar comment
Author
|
For a bit more detail this just uses the more explicit version of the java.sql.setObject |
21d2b3e to
d31d9a9
Compare
|
hello - is there any problem with merging this PR ? This looks to address an issue i am seeing |
Owner
|
@darrenallen85 the problem I'm currently facing is that Travis is not working for me as I was expecting it. I'll need to take a closer look on how compatible it is with all the supported JPype and Jython versions and of course all the different JDBC drivers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57 by using the setobject method containing three arguments.