Add compute method and remove Catalog interface from CatalogMesh.#498
Merged
rainwoodman merged 4 commits intobccp:masterfrom Jun 1, 2018
Merged
Add compute method and remove Catalog interface from CatalogMesh.#498rainwoodman merged 4 commits intobccp:masterfrom
rainwoodman merged 4 commits intobccp:masterfrom
Conversation
rainwoodman
changed the title
Member
Author
|
This PR is one step closer to a clean merge of #450 . I stopped adding .compute() method to the algorithms, because it would require lifting the load / save method to a new class, which seems to be an overkill. |
Member
Author
|
Replaces #484 |
This is required to add a compute method to MeshSource. Because if CatalogMesh is a CatalogSource then CatalogSource.compute comes into the way. I think this PR also sheds some light on how to deal with the temporary variables created during FKP/convpower. They probably shall be saved as attributes of the CatalogMesh objects directly, rather than stored as columns of the underlying sources.
rainwoodman
force-pushed
the
compute-method
branch
from
78a3492 to
5dc1033
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to add a compute method to MeshSource. Because
if CatalogMesh is a CatalogSource then CatalogSource.compute comes
into the way.
I think this PR also sheds some light on how to deal with the temporary
variables created during FKP/convpower. They probably shall be saved
as attributes of the CatalogMesh objects directly, rather than stored
as columns of the underlying sources.