33282 - New onboarding BI notebook to include stats around the filings done in the modernized system#4365
Open
ketaki-deodhar wants to merge 3 commits into
Open
33282 - New onboarding BI notebook to include stats around the filings done in the modernized system#4365ketaki-deodhar wants to merge 3 commits into
ketaki-deodhar wants to merge 3 commits into
Conversation
|
ketaki-deodhar
changed the title
argush3
reviewed
May 11, 2026
| " FROM businesses b\n", | ||
| " JOIN filings f ON b.id = f.business_id\n", | ||
| " WHERE\n", | ||
| " f.status = 'TOMBSTONE'\n", |
Collaborator
There was a problem hiding this comment.
We should probably check against the filing_type being ='lear_tombstone'.
filing.status can change to "BACKFILLED" after we backfill the historical data. If this happened, the current code would exclude all businesses that have had historical data backfilled.
argush3
reviewed
May 11, 2026
Comment on lines
+122
to
+123
| " STRING_AGG(f.filing_date::text, ', '), ''\n", | ||
| " ) AS \"{column_names['filing_date']}\"\n", |
Collaborator
There was a problem hiding this comment.
can you check with Vikas what date format he wants for the filing date. In current form of the migration status spreadsheet, we don't include timestamp
argush3
approved these changes
May 11, 2026
Collaborator
argush3
left a comment
argush3
left a comment
There was a problem hiding this comment.
looks good.
just the 2 things i mentioned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#33282
Description of changes:
Create a new onboarding BI notebook to include following columns which will be derived from colin extract and business db
Sheet format:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).