Open
Fix ComboBox popup layout when opened at viewport bottom edge#1351
Conversation
Co-authored-by: bdlukaa <45696119+bdlukaa@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ComboBox rendering exception at bottom of screen
Fix ComboBox popup layout when opened at viewport bottom edge
Aug 28, 2026
bdlukaa
marked this pull request as ready for review
August 29, 2026 18:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComboBoxcould hit a debug layout assertion when the control was fully aligned to the bottom of the viewport, causing the popup to render with an invalid vertical position. This change hardens popup placement so the menu always stays within available bounds.Popup layout clamping
_ComboBoxMenuRouteLayout.getPositionForChildto clamp the computed popuptopbased on the actualchildSize.heightand viewport height.menuLimits.top + menuLimits.height <= size.height) with bounds checks on the clamped position used for rendering.Regression test for bottom-edge placement
ComboBoxat the bottom of a fixed-height viewport, opens it, and asserts no exception is thrown while menu items render correctly.Changelog update
4.16.2entry documenting theComboBoxbottom-edge assertion fix.ComboBoxthrows rendering exception when it is rendered at the bottom of the screen #1350