Skip to content

Add support for SHA-384 hash algorithm#1789

Open
sorooshm78 wants to merge 3 commits intobeemdevelopment:masterfrom
sorooshm78:sha384-support
Open

Add support for SHA-384 hash algorithm#1789
sorooshm78 wants to merge 3 commits intobeemdevelopment:masterfrom
sorooshm78:sha384-support

Conversation

@sorooshm78
Copy link
Copy Markdown

Thanks for the great app. I needed SHA-384 support for my use case, which wasn’t available in Aegis, so I implemented it. Opening this PR so others can benefit as well.

Copy link
Copy Markdown
Member

@alexbakker alexbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've previously closed #1679 because we couldn't find any services using SHA-384 for TOTP. Which service did you encounter that requires it?

Comment thread app/src/main/proto/google_auth.proto Outdated
@sorooshm78
Copy link
Copy Markdown
Author

sorooshm78 commented Apr 25, 2026

Hi @alexbakker,

Thanks for getting back to me. I encountered this requirement within our organization. We use a custom internal enterprise SSO and VPN gateway where the network administrators have specifically configured the TOTP generation to use SHA-384.

Regarding your second question, as far as I know, Google Authenticator does not support SHA-384. I only added ALGORITHM_SHA384 = 5 to google_auth.proto for the sake of completeness in the code.

I can completely revert the changes made to the .proto file (and related Google Auth migration code) and only keep the core SHA-384 implementation for Aegis itself. Let me know if you’d like me to update the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants