-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Remove beets.mediafile deprecation warning #6016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR fully removes the long-deprecated beets.mediafile module by deleting its implementation file and cleans up the corresponding deprecation warning entry in the project changelog. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2b50c1b to
c87091c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated beets.mediafile module that has been showing a deprecation warning since version 1.6.0. The module was a compatibility shim that imported and re-exported everything from the mediafile module.
- Completely removes the
beets/mediafile.pyfile - Updates the changelog to document the removal for packagers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| beets/mediafile.py | Complete removal of deprecated compatibility module |
| docs/changelog.rst | Documents the removal in changelog for packagers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6016 +/- ##
==========================================
+ Coverage 66.52% 66.54% +0.02%
==========================================
Files 117 116 -1
Lines 18084 18077 -7
Branches 3061 3059 -2
==========================================
Hits 12030 12030
+ Misses 5403 5396 -7
Partials 651 651 🚀 New features to boost your workflow:
|
c87091c to
d46365f
Compare
JOJ0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! it's time! :-) Thanks!
snejus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a major version increase in order to remove it.
|
Added 3.0.0 as milestone. Might help us keep track of it. |
I propose we remove the deprecation warning for
beets.mediafile. This warning was introduced in version 1.6.0.While we could schedule the removal for version 3.0.0, it should be safe to remove it now since the feature has been deprecated for over three years.
ref: #4263