-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Accept lyrics source as a string #6149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `docs/changelog.rst:33-34` </location>
<code_context>
+- :doc:`plugins/lyrics`: Accepts strings for lyrics sources (used to only accept
+ list of strings). :bug:`5962`
</code_context>
<issue_to_address>
**suggestion (typo):** Minor grammatical issue: missing article in 'used to only accept list of strings'.
Change to 'previously only accepted a list of strings' for correct grammar.
```suggestion
- :doc:`plugins/lyrics`: Accepts strings for lyrics sources (previously only accepted a list of strings). :bug:`5962`
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6149 +/- ##
==========================================
+ Coverage 67.34% 67.55% +0.21%
==========================================
Files 136 136
Lines 18492 18492
Branches 3134 3134
==========================================
+ Hits 12453 12493 +40
+ Misses 5370 5329 -41
- Partials 669 670 +1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This is my first PR. Please feel free to give feedback or things I should change. |
|
Thank you for the PR! We're thrilled to have you contributing, welcome to the community! |
Description
Fixes #5962 .
The fix was shared in the issue. Now it uses
as_str_seqsimilarly to other plugins.To Do
Documentation. (If you've added a new command-line flag, for example, find the appropriate page underdocs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)Tests. (Very much encouraged but not strictly required.)