Skip to content

Conversation

@DogeTheBeast
Copy link
Contributor

Description

Fixes #5962 .

The fix was shared in the issue. Now it uses as_str_seq similarly to other plugins.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

@DogeTheBeast DogeTheBeast requested a review from a team as a code owner November 7, 2025 01:29
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `docs/changelog.rst:33-34` </location>
<code_context>
+- :doc:`plugins/lyrics`: Accepts strings for lyrics sources (used to only accept
+ list of strings).  :bug:`5962`
</code_context>

<issue_to_address>
**suggestion (typo):** Minor grammatical issue: missing article in 'used to only accept list of strings'.

Change to 'previously only accepted a list of strings' for correct grammar.

```suggestion
- :doc:`plugins/lyrics`: Accepts strings for lyrics sources (previously only accepted a list of strings).  :bug:`5962`
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@DogeTheBeast DogeTheBeast marked this pull request as draft November 7, 2025 01:32
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.55%. Comparing base (61a4c73) to head (26a8e16).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6149      +/-   ##
==========================================
+ Coverage   67.34%   67.55%   +0.21%     
==========================================
  Files         136      136              
  Lines       18492    18492              
  Branches     3134     3134              
==========================================
+ Hits        12453    12493      +40     
+ Misses       5370     5329      -41     
- Partials      669      670       +1     
Files with missing lines Coverage Δ
beetsplug/lyrics.py 86.61% <100.00%> (+8.11%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DogeTheBeast DogeTheBeast marked this pull request as ready for review November 7, 2025 02:17
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@DogeTheBeast
Copy link
Contributor Author

This is my first PR. Please feel free to give feedback or things I should change.

@semohr semohr self-assigned this Nov 7, 2025
@semohr
Copy link
Contributor

semohr commented Nov 7, 2025

Thank you for the PR!

We're thrilled to have you contributing, welcome to the community!

@semohr semohr merged commit 7cca07d into beetbox:master Nov 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lyrics: sources can be a string and beets doesn't complain

2 participants