Skip to content

Removed tox for a plain github action workflow and updated flit_core #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 17, 2025
Merged

Removed tox for a plain github action workflow and updated flit_core #88

merged 4 commits into from
Nov 17, 2025

Conversation

@semohr
Copy link
Contributor

@semohr semohr commented Oct 28, 2025 •
edited by JOJ0
Loading

Moved from #86

  • Remove Tox in favor of plain GitHub Actions for testing
  • Remove coverage report for now
  • Update flitcore and modernize pyproject toml.

@semohr semohr requested a review from a team November 12, 2025 10:50
@semohr
Copy link
Contributor Author

semohr commented Nov 12, 2025

@beetbox/maintainers Can I get a look here? This is blocking #86 for me.

JOJ0
JOJ0 approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@JOJ0 JOJ0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - except that this commit doesn't do much, maybe squash into one of the others if possible? 5f09152

@semohr
Copy link
Contributor Author

semohr commented Nov 13, 2025

Let's just do a squash merge. I dont think the history is important here 👍

@JOJ0
Copy link
Member

JOJ0 commented Nov 14, 2025

@semohr yes good idea. lets do that

@JOJ0 JOJ0 merged commit 1d1fa38 into master Nov 17, 2025
11 checks passed
@JOJ0 JOJ0 deleted the flit-upgrade branch November 17, 2025 06:49
@JOJ0 JOJ0 mentioned this pull request Nov 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JOJ0 JOJ0 JOJ0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@semohr @JOJ0