Feature/fix build without modules #208
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
requested review from
camio,
dietmarkuehl and
neatudarius
as code owners
ClausKlein
commented
Jan 30, 2026
Comment on lines
+76
to
+85
| set_target_properties( | ||
| "${target_name}_${interface}" | ||
| PROPERTIES EXPORT_NAME "${component_name}_${interface}" | ||
| ) | ||
| message( | ||
| VERBOSE | ||
| "beman-install-library: COMPONENT ${component_name}_${interface} for TARGET '${name}_${interface}'" | ||
| ) | ||
| list(APPEND target_list "${target_name}_${interface}") | ||
| endif() |
Collaborator
Author
There was a problem hiding this comment.
@ednolan my quick and dirty hack to install the module library and the interface library
ClausKlein
commented
Jan 30, 2026
Comment on lines
+21
to
+25
| # PUBLIC | ||
| # FILE_SET ${TARGET_NAME}_detail_headers | ||
| # TYPE HEADERS | ||
| # BASE_DIRS ${PROJECT_SOURCE_DIR}/include | ||
| # FILES |
Collaborator
Author
There was a problem hiding this comment.
@dietmarkuehl sorry, no named FILE_SET possible at the moment!
Additional problem:
CMake Error at src/beman/execution/CMakeLists.txt:11 (target_sources):
target_sources Non-default file set name must contain only letters,
numbers, and underscores, and must not start with a capital letter or
underscore
ClausKlein
commented
Jan 30, 2026
| target_link_libraries( | ||
| ${EXAMPLE_TARGET} | ||
| PRIVATE beman::beman_execution_headers | ||
| PRIVATE beman::execution_headers |
Collaborator
Author
There was a problem hiding this comment.
@ednolan @dietmarkuehl now the exported target names are conform to the beman rules
ClausKlein
commented
Jan 30, 2026
| include(cmake/prelude.cmake) | ||
|
|
||
| #=================================================== | ||
| project(beman_execution VERSION 0.1.0 LANGUAGES CXX) |
Collaborator
Author
There was a problem hiding this comment.
TODO: should be beman.execution, but than
CMake Error at src/beman/execution/CMakeLists.txt:11 (target_sources):
target_sources Non-default file set name must contain only letters,
numbers, and underscores, and must not start with a capital letter or
underscore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3bb4ba9 Use beman-install-library-config.cmake
fd9ae94 Feat: configure project to test without modules