Add various string conversion utilities #294
Open
+64
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Jun 6, 2019
| .. function:: str_to_binary(s, encoding='utf-8', errors='strict') | ||
|
|
||
| Encodes s to :data:`binary_type` in python 3 only. No-op in python 2. | ||
| *encoding*, *errors* are same as :meth:`py3.str.encode` |
There was a problem hiding this comment.
For completeness, I'd mention the type of the argument (it's possible to infer it from the rest but it took me a while). And do this for all functions.
gvanrossum
approved these changes
Jun 6, 2019
Owner
|
The main thing that makes me queasy about these is that |
|
IIUC @jhance found a lot of situations where these would be really handy. Maybe he can quote some here? Or you two can discuss in person. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently six provides
ensure_str,ensure_text, andensure_binary. Typically these are used when you have astrobject and want to convert to text or bytes, or the inverse.I'd prefer to be explicit about which conversion I'm doing. For example, using
six.ensure_binaryshould probably not be accepting text in py2 and should not be accepting binary in py3 (for most use cases). Effectively these equivalents make the code a little stricter about what types are actually expected.They should also be more performant as they avoid an
isinstancelookup on every conversion.