Repository navigation
Pin the clock in the loss-time test - #372
Merged
Merged
Conversation
The test sampled the clock when sending and again when acknowledging, so a stalled runner could let the loss delay pass in between and declare the packet lost before the deadline was looked for. It now uses fixed times and asserts the exact deadline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quic_loss_tests:get_loss_time_with_packets_testsampled the clock when sending and again when acknowledging. On a stalled macOS runner the loss delay passed in between, the packet was declared lost outright, and the test failed looking for a deadline that no longer existed (seen once on #371, passed on rerun).The test now sends and acknowledges at fixed times through
on_packet_sent/7and asserts the exact deadline, the send time plus 9/8 of the first RTT sample.