This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Toolbar width no longer limited to editable content width - #129
Open
constfun wants to merge 1 commit into
Open
Conversation
There is no reason why the fixed toolbar size should be limited to the content you are editing.
Owner
|
@pacemkr it seems your patch makes some of our tests fail. Can you look at that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When editing content that is in a narrow column the toolbar is wrapped to the same width as the content. This default is impossible to change without hacking up hallo since the width is set to the "style" attribute of hallotoolbar.
Solution: Keep it minimal by not messing with the width of the toolbar. =)