fix: add missing getContentByUrl import to crawl endpoint#651
Open
joelrb wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
functions/api/crawl.tscallsgetContentByUrl(env, targetUrl, crawler)on line 256 to look up cached content when?force=trueis not specified. However,getContentByUrlwas missing from the import statement on line 2. At runtime this throwsReferenceError: getContentByUrl is not defined, breaking the entire "fetch from cache" code path. Every non-force crawl request crashes instead of returning cached content.Fix Applied
Added
getContentByUrlto the named import on line 2 offunctions/api/crawl.ts.Framework Change
No framework changes.
Files Changed
functions/api/crawl.ts— AddedgetContentByUrlto import statement (line 2)Security Severity: Low
Type of Change
Related Issues
Fixes #missing-getcontentbyurl-import
Testing
Describe the testing performed for this PR:
Include specific test scenarios or commands used.
Manual test:
getContentByUrlis exported fromfunctions/lib/crawler.tscrawl.tsline 2 now includesgetContentByUrlcrawl.tsline 256 matches the imported function nameChecklist
Performance & Security
Screenshots (if applicable)
N/A
Additional Notes
This was introduced in the merged security fix #640. The
getContentByUrlfunction was correctly added to the crawl endpoint's logic but was omitted from the import statement. This is a one-line fix that restores the "fetch from cache" code path in the crawl endpoint.