0.19: Add more images#2493
Merged
Merged
Conversation
Zeophlite
approved these changes
Jun 15, 2026
cart
reviewed
Jun 15, 2026
Member
There was a problem hiding this comment.
This video is too large, too long, and includes OS chrome. I'm re-recording it.
Contributor
Author
There was a problem hiding this comment.
For future reference: how long can a video be?
Member
There was a problem hiding this comment.
Its not about how long a video can be. Its about how long it should be, given the context. Each second "wasted" results in slower page loads and wasted reader time.
cart
reviewed
Jun 15, 2026
cart
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2474 and together with #2484 it should cover all but one
TODO: add image.One last thing we'd still maybe want to show is resizing text based on window size.