Skip to content

Run prepass_build_indirect_parameters if there is any prepass #24113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 1 commit into from
May 5, 2026
+11 −3
Merged

Run prepass_build_indirect_parameters if there is any prepass #24113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions crates/bevy_pbr/src/render/gpu_preprocess.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ use bevy_core_pipeline::{
mip_generation::experimental::depth::{early_downsample_depth, ViewDepthPyramid},
prepass::{
node::{early_prepass, late_prepass},
DepthPrepass, PreviousViewData, PreviousViewUniformOffset, PreviousViewUniforms,
DeferredPrepass, DepthPrepass, MotionVectorPrepass, NormalPrepass, PreviousViewData,
PreviousViewUniformOffset, PreviousViewUniforms,
},
schedule::{Core3d, Core3dSystems},
};
Expand Down Expand Up @@ -383,6 +384,13 @@ pub struct ViewPhaseBinUnpackingBindGroup {
#[derive(Component, Default)]
pub struct SkipGpuPreprocess;

type WithAnyPrepass = Or<(
With<DepthPrepass>,
With<NormalPrepass>,
With<MotionVectorPrepass>,
With<DeferredPrepass>,
)>;

impl Plugin for GpuMeshPreprocessPlugin {
fn build(&self, app: &mut App) {
embedded_asset!(app, "mesh_preprocess.wgsl");
Expand Down Expand Up @@ -436,7 +444,7 @@ impl Plugin for GpuMeshPreprocessPlugin {
With<PreprocessBindGroups>,
Without<SkipGpuPreprocess>,
Without<NoIndirectDrawing>,
Or<(With<DepthPrepass>, With<ShadowView>)>,
Or<(WithAnyPrepass, With<ShadowView>)>,
)>),
)
.chain()
Expand All @@ -447,7 +455,7 @@ impl Plugin for GpuMeshPreprocessPlugin {
With<PreprocessBindGroups>,
Without<SkipGpuPreprocess>,
Without<NoIndirectDrawing>,
Or<(With<DepthPrepass>, With<ShadowView>)>,
Or<(WithAnyPrepass, With<ShadowView>)>,
With<OcclusionCulling>,
)>),
)
Expand Down