Features register by githublaohu · Pull Request #19 · bfenetworks/api-server

githublaohu · 2022-02-16T06:51:22Z

No description provided.

pool split

mileszhang2016 · 2022-06-02T02:08:39Z


-	for typ := range type2InstancePoolList {
-		_, ok := pim.instancePoolStorages[typ]
+	for type2 := range type2PoolList {


type2 => type?
如果type是保留字，可以用typeName。
type2不知道是什么意思

mileszhang2016 · 2022-06-02T02:15:13Z

 	rst := map[string]*InstancePool{}
-	for typ, pisList := range type2InstancePoolList {
-		storager := pim.instancePoolStorages[typ]
+	for type2, pisList := range type2PoolList {


mileszhang2016 · 2022-06-02T02:33:11Z

+// CanDelete check whether pool can be deleted, Check Logic:
+// 1. Not BFE Cluster Refer To
+// 2. Not SubCluster Refer To
+func (m *PoolManager) CanDelete(ctx context.Context, pool *Pool) error {


这个函数的返回值有些问题。
从函数名字看，应该“逻辑判断型”的返回值。
建议返回值改为 (bool, error)，第一个返回值返回true/false，第二个返回错误的信息

这个问题并没有答复或解决

mileszhang2016 · 2022-06-02T02:43:01Z

+	return
+}
+
+func (m *PoolManager) FetchBFEPools(ctx context.Context) (list []*Pool, err error) {


这个函数存在的意义是？

这个问题没有答复呀

mileszhang2016 · 2022-06-02T02:44:51Z

+	return
+}
+
+func poolNameJudger(productName string, poolName string) (realName string, err error) {


poolNameJudger => poolNameGet

*er一般是一个对象。这个函数显然只是一个操作

如果语义是judge/check，就没有“修改”的含义。改为Get后会好很多

这个问题也没有任何的解释和答复

mileszhang2016 · 2022-06-02T02:47:25Z

+
+type PoolManager struct {
+	storage            PoolStorage
+	bfeClusterStorager ibasic.BFEClusterStorager


Storager => Storage
所有代码的都替换一下吧。
既然line 27已经是storage，那就统一风格

本次设计里面没有编写BFEClusterStorager，是以前的代码

mileszhang2016 · 2022-06-02T02:49:22Z

+
+func (m *PoolManager) CreateProductPool(ctx context.Context, product *ibasic.Product, param *PoolParam, pool *InstancePool) (one *Pool, err error) {
+	var pN string
+	pN, err = poolNameJudger(product.Name, *param.Name)


pN => poolName。
pN这样的缩写完全看不懂，是非常差的起名方式。
缩写还是要让人能看懂

mileszhang2016 · 2022-06-20T06:25:34Z

+var _ icluster_conf.InstancePoolStorage = &RDBInstancePoolStorage{}
+
+func (rpps *RDBInstancePoolStorage) UpdateInstances(ctx context.Context, pool *icluster_conf.Pool,
+	pis *icluster_conf.InstancePool) error {


pis这个缩写并不合适，改为iPool?

mileszhang2016 · 2022-06-20T06:26:33Z

+	return err
+}
+
+func (rpps *RDBInstancePoolStorage) BatchFetchInstances(ctx context.Context,


rpps不知道是什么的缩写

mileszhang2016 · 2022-06-20T06:27:50Z

 }

-func (rpps *RDBPoolStorager) DeletePool(ctx context.Context, pool *icluster_conf.Pool) error {
+func (rpps *RDBPoolStorage) DeletePool(ctx context.Context, pool *icluster_conf.Pool) error {


rpps => s, 或 rps

mileszhang2016 · 2022-06-20T06:28:02Z

 }

-func (rpps *RDBPoolStorager) UpdatePool(ctx context.Context, oldData *icluster_conf.Pool,
+func (rpps *RDBPoolStorage) UpdatePool(ctx context.Context, oldData *icluster_conf.Pool,


rpps => s, 或 rps

mileszhang2016 · 2022-06-20T06:29:16Z

 }

-func (rpps *RDBPoolStorager) CreatePool(ctx context.Context, product *ibasic.Product,
+func (rpps *RDBPoolStorage) CreatePool(ctx context.Context, product *ibasic.Product,


rpps => s, 或 rps

mileszhang2016 · 2022-06-20T07:10:51Z

+
+	rst := map[string]*InstancePool{}
+	for type2, pisList := range type2PoolList {
+		storager := m.instancePoolStorages[type2]


storager => storage

mileszhang2016 · 2022-06-20T07:11:33Z

+	return rst, nil
+}
+
+func (m *InstancePoolManager) UpdateInstances(ctx context.Context, pool *Pool, pis *InstancePool) error {


pis => iPool

mileszhang2016 · 2022-06-20T07:12:47Z

+	return
+}
+
+func (m *PoolManager) FetchBFEPools(ctx context.Context) (list []*Pool, err error) {


这个问题没有答复呀

mileszhang2016 · 2022-06-20T07:13:29Z

+	return
+}
+
+func poolNameJudger(productName string, poolName string) (realName string, err error) {


这个问题也没有任何的解释和答复

mileszhang2016 · 2022-06-20T07:14:09Z

+// CanDelete check whether pool can be deleted, Check Logic:
+// 1. Not BFE Cluster Refer To
+// 2. Not SubCluster Refer To
+func (m *PoolManager) CanDelete(ctx context.Context, pool *Pool) error {


这个问题并没有答复或解决

bumu · 2023-04-18T15:03:26Z

What's the progress

laohu and others added 6 commits February 6, 2022 11:08

fix(*):1. 基本完成register模块开发，2.完成register-nacos开发

e4a388e

pool split

95055e8

Merge pull request #1 from liuximu/features-register

b8f946a

pool split

fix(*):按照讨论结果重写设计与开发整个regsiter

97a7ac4

fix(model,starage,stateful,conf): 完成nacos作为注册中心

404c8df

回滚配置

e02c95c

mileszhang2016 requested changes Feb 16, 2022

View reviewed changes

Comment thread .vscode/launch.json Outdated

fix(.gitignore)：添加过滤

09031eb

liuqing6767 suggested changes Feb 18, 2022

View reviewed changes

fix(*):1. 异常加强

e4cd5ec

liuqing6767 mentioned this pull request Feb 23, 2022

How to extend instance pool with discover service? #21

Open

mileszhang2016 requested changes Mar 3, 2022

View reviewed changes

laohu added 3 commits March 21, 2022 02:28

fix(*):1. 修正命名，2. 配置文件中连接错误

fca98ea

fix(*):修正命名

3190310

fix(*):修改命名

28ab6e2

mileszhang2016 requested changes Apr 6, 2022

View reviewed changes

laohu added 2 commits May 5, 2022 23:44

fix(*):修改命名

9577254

fix(model):添加pool_manager.go

840c7ce

mileszhang2016 requested changes Jun 2, 2022

View reviewed changes

mileszhang2016 requested changes Jun 20, 2022

View reviewed changes

Conversation

githublaohu commented Feb 16, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

githublaohu Jun 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bumu commented Apr 18, 2023

githublaohu Jun 7, 2022 •

edited

Loading