-
Notifications
You must be signed in to change notification settings - Fork 346
feat(catalyst): CATALYST-1665 Hide "Exclusive Offers" field from account registration [temporary] #2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(catalyst): CATALYST-1665 Hide "Exclusive Offers" field from account registration [temporary] #2800
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| --- | ||
| "@bigcommerce/catalyst-core": patch | ||
| --- | ||
|
|
||
| Remove "Exclusive Offers" field temporarily. Currently, the field is not fully implemented in GraphQL, so it may be misleading to display it on the storefront if it's not actually doing anything when registering a customer. | ||
|
|
||
| Once the Register Customer operation takes this field into account, we can display it again. | ||
|
|
||
| ## Migration | ||
|
|
||
| Update `core/app/[locale]/(default)/(auth)/register/page.tsx` and add the function: | ||
| ```ts | ||
| // There is currently a GraphQL gap where the "Exclusive Offers" field isn't accounted for | ||
| // during customer registration, so the field should not be shown on the Catalyst storefront until it is hooked up. | ||
| function removeExlusiveOffersField(field: Field | Field[]): boolean { | ||
| if (Array.isArray(field)) { | ||
| // Exclusive offers field will always have ID '25', since it is made upon store creation and is also read-only. | ||
| return !field.some((f) => f.id === '25'); | ||
| } | ||
|
|
||
| return field.id !== '25'; | ||
| } | ||
| ``` | ||
|
|
||
| Then, add the following code at the end of the `const fields` declaration: | ||
| ```ts | ||
| }) | ||
| .filter(exists) | ||
| .filter(removeExlusiveOffersField); // <--- | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.