Open
Conversation
marghoob
reviewed
Apr 19, 2021
| // std::cout << "elapsed_3p0 time: " << elapsed_seconds_3p0.count() << "s\n"; | ||
| // auto start_3p1 = std::chrono::system_clock::now(); | ||
|
|
||
| if (calculate_qual) { |
There was a problem hiding this comment.
ii is used both in the outermost and the innermost loops. Better to have different names here.
marghoob
reviewed
Apr 19, 2021
| bool calculate_qual_stat_ = false; | ||
| bool fully_contained_ = false; | ||
| float min_allele_freq_ = 0.01; | ||
| float snp_min_allele_freq_ = 0.01; |
There was a problem hiding this comment.
Such constants should be declared somewhere else. Things like these would be good candidates for refactoring the code.
marghoob
reviewed
Apr 19, 2021
|
|
||
|
|
||
|
|
||
| auto start_main = std::chrono::system_clock::now(); |
There was a problem hiding this comment.
Using scoped timers would simplify this performance measurement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving preprocessing speed