Skip to content

Guard missing peer addr in connect_dag assertions #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashishkrshaw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Guard missing peer addr in connect_dag assertions #798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions resources/scenarios/test_scenarios/connect_dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,12 @@ def assert_connection(self, connector, connectee_index, connection_type: Connect
if connection_type == ConnectionType.DNS:
assert any(
# ignore the ...-service suffix
self.nodes[connectee_index].tank in d.get("addr")
self.nodes[connectee_index].tank in (d.get("addr") or "")
for d in connector
), "Could not find conectee hostname"
), "Could not find connectee hostname"
elif connection_type == ConnectionType.IP:
assert any(
d.get("addr").split(":")[0] == self.nodes[connectee_index].rpchost
(d.get("addr") or "").split(":")[0] == self.nodes[connectee_index].rpchost
for d in connector
), "Could not find connectee ip addr"
else:
Expand Down