Add tests for AndroidRecurringCalendar
#139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `testAddEventAndExceptions` to `testAddEventAndExceptions_and_GetById` - Implement `testFindEventAndExceptions` and `testFindEventAndExceptions_NotFound` - Implement `testGetById_NotFound` - Implement `testIterateEventAndExceptions` and `testIterateEventAndExceptions_NotFound` - Add helper function `insertRecurring` to reduce code duplication
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for several public methods in AndroidRecurringCalendar and improves documentation for exception handling requirements.
- Adds test coverage for
findEventAndExceptions,getById, anditerateEventAndExceptionsmethods - Refactors existing test to use a reusable helper method
- Clarifies documentation about sync ID requirements for exception events
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/src/main/kotlin/at/bitfire/synctools/storage/calendar/AndroidRecurringCalendar.kt | Enhanced documentation for addEventAndExceptions to clarify the requirement for setting Events._SYNC_ID and Events.ORIGINAL_SYNC_ID when working with exception events |
| lib/src/androidTest/kotlin/at/bitfire/synctools/storage/calendar/AndroidRecurringCalendarTest.kt | Added tests for findEventAndExceptions, getById, and iterateEventAndExceptions methods, including both success and not-found scenarios; refactored test code to use a reusable insertRecurring helper method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some missing tests