Skip to content

[PM-24364] fix: [Android] Import logins card is not dismissed [bug-factory poc] #7486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrebispo5 merged 2 commits into from
Oct 15, 2026
+8 −4
Merged

[PM-24364] fix: [Android] Import logins card is not dismissed [bug-factory poc] #7486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a98eb7
[PM-24364] fix: [Android] Import logins card is not dismissed [bug-fa…
Oct 14, 2026
e1e06f0
Use dismissDialog helper and shorten test name
andrebispo5 Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...rc/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ class ImportLoginsViewModel @Inject constructor(
}

private fun handleFailedSyncAcknowledged() {
mutableStateFlow.update {
it.copy(dialogState = null)
}
dismissDialog()
firstTimeActionManager.storeShowImportLogins(showImportLogins = false)
firstTimeActionManager.storeShowImportLoginsSettingsBadge(showBadge = true)
sendEvent(ImportLoginsEvent.NavigateBack)
}

Expand Down
6 changes: 5 additions & 1 deletion ...est/kotlin/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ class ImportLoginsViewModelTest : BaseViewModelTest() {
}

@Test
fun `FailSyncAcknowledged should remove dialog state and send NavigateBack event`() =
fun `FailSyncAcknowledged clears dialog, navigates back, and stores first time values`() =
runTest {
coEvery {
vaultRepository.syncForResult(forced = true)
Expand All @@ -447,6 +447,10 @@ class ImportLoginsViewModelTest : BaseViewModelTest() {
awaitItem(),
)
}
verify(exactly = 1) {
firstTimeActionManager.storeShowImportLogins(showImportLogins = false)
firstTimeActionManager.storeShowImportLoginsSettingsBadge(showBadge = true)
}
}

@Suppress("MaxLineLength")
Expand Down
Loading