Repository navigation
llm: Push SDK-update evaluation fixes with a freshly minted app token - #7491
SaintPatrck wants to merge 1 commit into
Conversation
Installation tokens expire an hour after they are minted. When the Claude step runs long, the token generated at the start of the job has expired by the time the push runs, and the push fails with "Invalid username or token", discarding Claude's fix commit.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR changes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7491 +/- ##
=======================================
Coverage 86.80% 86.80%
=======================================
Files 895 895
Lines 65684 65684
Branches 9385 9385
=======================================
Hits 57015 57015
Misses 5189 5189
Partials 3480 3480
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
Failed SDK-update evaluation run: https://github.com/bitwarden/android/actions/runs/38936477036
📔 Objective
The GitHub App installation token we mint at the start of the SDK-update evaluation job expires after an hour, so whenever the Claude step runs long the push fails with "Invalid username or token" and Claude's fix commit is discarded. The push now authenticates with a token minted after Claude finishes, so it succeeds however long the evaluation takes.
🤖 AI-assisted review
Standard local review (
code-review-local) approved with no findings.