[CL-944] update layout components to support constrained height contexts

[willmartian]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-944

📔 Objective

Refactor bit-layout and related components to support constrained height contexts (desktop).

• Set tw-h-screen on bit-layout host element (default full-screen behavior)
  • this can now be overridden easily in desktop, <bit-layout class="!tw-h-full">
• Changed all internal height classes from tw-h-screen to tw-h-full
• Updated components: bit-layout, bit-side-nav, bit-drawer, bit-dialog

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 3ac13273-7d93-4c08-9746-3234205aebd9

Great job! No new security vulnerabilities introduced in this pull request

[claude]

Claude finished @willmartian's task —— View job

---

PR Review Complete

The implementation is clean and achieves the objective effectively. The refactoring from tw-h-screen to tw-h-full for internal components with tw-h-screen on the host element provides the flexibility needed for constrained height contexts.

Findings

Finding 1: The PR title and description are clear and well-structured, with proper Jira tracking and objective explanation.

Finding 2: Changes are consistent across all modified components - all internal tw-h-screen classes correctly changed to tw-h-full, and host elements properly configured.

Finding 3 (💭): In drawer-body.component.ts:14, the change from tw-block to tw-flex-1 is not mentioned in the PR description. While this change makes sense for proper flex layout behavior, consider noting it in the objective section for completeness.

Suggested description addition

In the "Objective" section, after the bullet points, you could add:

  - Changed `bit-drawer-body` from `tw-block` to `tw-flex-1` for proper flex container behavior

Finding 4 (💭): In dialog.component.ts:107, the change from tw-min-h-screen to tw-h-full for drawers differs from other components that went from tw-h-screen to tw-h-full. Was tw-min-h-screen (minimum height) intentionally used before, or was this an inconsistency that this PR also fixes?

Summary

The implementation is solid with proper Tailwind prefix usage throughout. All changes correctly implement the constrained height pattern. The two findings above are for clarification purposes and don't block approval.