[PM-28943] Feature/pm 27794 create send component desktop migration #17721
+799
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com:iivins-livefront/clients_LF_desktop_migration into feature/PM-27794-create-send-component-desktop-migration
|
|
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
…github.com:iivins-livefront/clients_LF_desktop_migration into feature/PM-27794-create-send-component-desktop-migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important to note*
send-v2.component.html,send-v2.component.ts,send-v2.component.spec.tsare relevant to that PR##Overview
The goal of this PR is to expand upon the layout scaffold provided by PM-27792 by implementing the complete Send management interface.
##Key Changes Made:
signal()for mutable state (sendId,action)computed()for derived values (selectedSendType)toSignal()for RxJS-to-Signal conversion of service observables@ifand@fordirectivesFilters were removed ( as per the AC's ) - and the work for component, re-adding filters, and updating the SendList is beyond scope of this ticket