Add HintItem and HintLocation commands for Archipelago - #596
Open
OmegaZeron wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this feature do
Adds Archipelago:HintItem and Archipelago:HintLocation functions. These will just use the pre-existing Say command to post
!hint [item]and!hint_location [location]to the server.Why is this feature wanted
The current hint functions either only work with the apmanual flag or will ignore AP's hint costs. For people using a tracker that doesn't have item or location names that match exactly what AP expects, it can be a chore to find the correct name. This way the tracker can send the correct names, or even IDs, to the server without the user having to find the info by digging through GitHub or DataPackage.
How was this tested
Potential improvements
if (_state < State::ROOM_INFO) // or SLOT_CONNECTED?. I am also unsure how much this matters because as far as I know PopTracker shouldn't ever be in ROOM_INFO state (at least that we can interact with) since the slot is required to connect, but it's possible this should be changed to SLOT_CONNECTED anyway