Skip to content

Fix index out of range panic when passing empty slice to NewIDSelectorBatch and NewIDSelectorBitmap #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jizhuozhi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix index out of range panic when passing empty slice to NewIDSelectorBatch and NewIDSelectorBitmap #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions selector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,14 @@ func NewIDSelectorRange(imin, imax int64) (Selector, error) {
// NewIDSelectorBatch creates a new batch selector.
func NewIDSelectorBatch(indices []int64) (Selector, error) {
var sel *C.FaissIDSelectorBatch
var dataPtr *C.idx_t
if len(indices) > 0 {
dataPtr = (*C.idx_t)(&indices[0])
}
if c := C.faiss_IDSelectorBatch_new(
&sel,
C.size_t(len(indices)),
(*C.idx_t)(&indices[0]),
dataPtr,
); c != 0 {
return nil, newFaissError(ErrCreateSelectorFailed, getLastError(), int(c))
}
Expand Down Expand Up @@ -93,10 +97,14 @@ func NewIDSelectorBatchNot(exclude []int64) (Selector, error) {
// The length of the bitmap should be at least ceil(N/8).
func NewIDSelectorBitmap(bitmap []byte) (Selector, error) {
var sel *C.FaissIDSelectorBitmap
var dataPtr *C.uint8_t
if len(bitmap) > 0 {
dataPtr = (*C.uint8_t)(&bitmap[0])
}
if c := C.faiss_IDSelectorBitmap_new(
&sel,
C.size_t(len(bitmap)),
(*C.uint8_t)(&bitmap[0]),
dataPtr,
); c != 0 {
return nil, newFaissError(ErrCreateSelectorFailed, getLastError(), int(c))
}
Expand Down