Conversation
jeremydw
force-pushed
the
fix/translation-metadata-undefined-value
branch
from
2cd1d64 to
0e828c4
Compare
stevenle
reviewed
Mar 23, 2026
| return; | ||
| } | ||
| this.pendingUpdates.set(key, value); | ||
| if (value === null || value === undefined) { |
Member
There was a problem hiding this comment.
i'm a little tempted to say null should remain (only undefined should be deleted). are there any use cases you can think of where we should support null? i'm thinking maybe for querying purposes since if the key is there it'll be search indexed whereas if the key is removed we won't be able to query for it.
Member
Author
There was a problem hiding this comment.
yeah; wasn't sure about this one. let's scope the change to just undefined for now and follow up with the null change later.
jeremydw
force-pushed
the
fix/translation-metadata-undefined-value
branch
from
0e828c4 to
f582d44
Compare
stevenle
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Firestore
invalid-argumenterror when saving translation metadata by converting undefined values todeleteField()inupdateKey(), and usingremoveKey()in EditTranslationsModal.