Skip to content

fix(chat): scroll to voice-submitted messages - #147

Merged
johnmatthewtennant merged 4 commits into
mainfrom
jtennant/fix-voice-submit-scroll
Aug 21, 2026
Merged

fix(chat): scroll to voice-submitted messages#147
johnmatthewtennant merged 4 commits into
mainfrom
jtennant/fix-voice-submit-scroll

Conversation

@johnmatthewtennant

@johnmatthewtennant johnmatthewtennant commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Submitting a message through voice conversation could render the new user turn without scrolling the transcript to it. The conversation stayed above the new message until assistant output arrived, even though composer submissions follow immediately.

Newly appended voice submissions now use the same reattach behavior as composer submissions in both transcript renderers. Stable voice-utterance identity prevents history replay, failed-delivery rollback, and backend message-ID acknowledgement from causing unrelated or repeated jumps.

Reviewer-reproducible example

  1. Open a chat with enough history to scroll, then scroll up until Jump to latest appears.
  2. Submit a new message through voice conversation.
  3. Confirm the user transcript appears and the chat follows it immediately, before the assistant responds.
  4. Scroll up again while the turn is being acknowledged. Confirm acknowledgement does not cause a second jump.

Manual verification

John confirmed in the Berd daily driver that a voice-submitted user turn scrolls into view immediately, before the assistant responds.

@johnmatthewtennant
johnmatthewtennant marked this pull request as ready for review August 20, 2026 18:08
@johnmatthewtennant
johnmatthewtennant requested a review from a team August 20, 2026 18:08
@johnmatthewtennant johnmatthewtennant changed the title fix(chat): follow voice-submitted messages fix(chat): scroll to voice-submitted messages Aug 20, 2026

@morgmart morgmart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated code review

APPROVE. Fresh static review of all 5 files in the exact three-dot comparison a1a41ce...c5e7ff1 found no publishable issues. The review covered both transcript renderers, voice-submission identity and acknowledgement behavior, detached/pinned scrolling, appended assistant continuation, history/replay and rollback suppression, lifecycle and race behavior, and the added regression tests. Final self-check covered every changed user flow; accessibility; i18n/localization completeness; navigation and consent guards; async, error, never-completes, lifecycle, and race behavior; test honesty; design-system and project laws; duplicate overlap; and blocking-severity evidence/user effect. No UI copy, controls, navigation, consent boundary, or styling tokens changed. Supplied GitHub evidence was inspected: eight check runs were completed successfully, while combined commit status was pending with no legacy statuses; required checks still independently govern merge readiness. No local code, tests, builds, package managers, generated binaries, hooks, or project scripts were run.

Deterministic publication result: 0 blocking and 0 non-blocking finding(s) publishable; 0 duplicate(s) suppressed.

Pending checks: 1 check(s) are not complete.

This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.

@johnmatthewtennant
johnmatthewtennant merged commit 8c35b2f into main Aug 21, 2026
8 checks passed
@johnmatthewtennant
johnmatthewtennant deleted the jtennant/fix-voice-submit-scroll branch August 21, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants