fix(chat): cancel superseded builder preparation - #78
Open
loganj wants to merge 6 commits into
Open
Conversation
Enable pending draft composers to queue messages while preserving the existing creation-readiness dispatch gate. Carry draft ownership and Agent Builder draft metadata across session promotion. Signed-off-by: Logan Johnson <loganj@squareup.com> Co-authored-by: Chai Landau <chai@block.xyz>
Specify composer-to-queue acceptance before readiness and rewrite chat laws with observable queue, dequeue, dispatch, and remove source-to-sink vocabulary. Signed-off-by: Logan Johnson <loganj@squareup.com>
Signed-off-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Signed-off-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Queued messages no longer pin the model and provider shown at queue time; dispatch may use whatever model and provider are selected when the message reaches the session. Persona retention is unchanged. Signed-off-by: Logan Johnson <loganj@squareup.com>
kalvinnchau
previously approved these changes
Aug 18, 2026
stack merge was automatically disabled
August 18, 2026 18:42
Pull Request is not mergeable
stack merge was automatically disabled
August 18, 2026 18:42
Pull Request is not mergeable
stack merge was automatically disabled
August 18, 2026 18:43
Pull Request is not mergeable
loganj
dismissed
kalvinnchau’s stale review
August 18, 2026 18:45
The merge-base changed after approval.
Base automatically changed from
morganm/queue-send-during-session-start
to
larry/chat-laws-queue-acceptance
August 18, 2026 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Prevents a removed or replaced queued Agent Builder message from finishing deferred draft preparation and leaving an orphan draft behind. Preparation now remains tied to the exact queued message that triggered it, and a draft created after that message loses authority is deleted before the chat session is updated.
This is PR 4 in the ordered stack: #64 → #65 → #68 → this PR. It builds on Morgan's defer-until-promotion architecture in #68; it does not merge or replace that work.
Related issue
N/A — follow-up correctness fix for #68.
Testing
0385e40855d99e3668dc455772653611ede58839: 539 files, 6309 passed, 1 skipped.