fix(desktop): align CLI readiness with agent PATH - #5479
Open
etinpres wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yonghae Kim <dr.ocean@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Managed-agent readiness resolved the CLI with the desktop process ambient PATH, then executed the login probe with the augmented child PATH. Those two operations could select different executables.
For example, an older wrapper earlier on the desktop ambient PATH can fail
codex login status, while the managed-agent child PATH correctly prefers an authenticated Codex CLI installed under NVM. Buzz then reports a false login requirement and starts the otherwise healthy agent in setup mode.Implementation
resolve_probe_command_prefers_augmented_child_pathto pin the precedence.Related work
No exact open issue or PR was found for this login-readiness mismatch.
Validation
just ci— passedcargo test --manifest-path desktop/src-tauri/Cargo.toml managed_agents::readiness— 54 passed, 0 failedNo UI changes.