fix(huddle): load voice instructions into system prompt - #5707
Merged
tlongwell-block merged 1 commit intoAug 12, 2026
Merged
Conversation
Co-authored-by: Wren <5217c5c2f7bfb4333e46d17c98a9255a52dadee18dcd43a43536b95e6776dfa0@buzz.block.builderlab.xyz> Signed-off-by: Wren <5217c5c2f7bfb4333e46d17c98a9255a52dadee18dcd43a43536b95e6776dfa0@buzz.block.builderlab.xyz>
tlongwell-block
commented
Aug 12, 2026
tlongwell-block
left a comment
Collaborator
Author
There was a problem hiding this comment.
Eva review at head 1a2f4d2 (confirmed == PR head; GitHub won't let this account formally approve since the PR was opened under the same login).
- Read the full 3-file diff. The owner-signature + exact-channel-h-tag gate on promoting kind 48106 into the system role is the right security posture: member-authored channel content must not gain system authority. Verify-then-check (signature, author, kind, h tag, non-empty) is complete.
- Ran full
cargo test -p buzz-acpat this exact head: 767 + 9 passed, 0 failed. Ran the full desktop Tauri workspace suite at this exact head: 2510 passed, 0 failed (includes the new 6-line prompt pin and the owner/channel rejection tests). - Fail-open on fetch timeout is correct here: worst case = old behavior, no huddle section.
- Accepted tradeoff, flagged by author: one filtered REST query per new channel-session creation, including non-huddle channels. Bounded by CONTEXT_FETCH_TIMEOUT; fine at this cost.
Verdict: 9/9/9 — ship-shaped. Stacked on #5671; merge after the base.
tlongwell-block
merged commit Aug 12, 2026
997f283
into
eva/huddle-first-audio-latency
28 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this seam
This reuses the existing per-channel
session/newprompt assembly and the already-posted kind48106event. It adds no new desktop-to-harness transport and performs one filtered relay query only when a new channel session is created. Failures are fail-open to no huddle section.Promoting ordinary channel messages would let arbitrary members inject system-level instructions. This path accepts only a valid event authored by the configured owner with the exact channel
htag.Testing
cargo test -p buzz-acp(767 unit + 9 lifecycle tests)cargo clippy -p buzz-acp --all-targets --all-features -- -D warningscargo fmt --all -- --checkStacked on #5671.